Skip to content

Conversation

@yaugenst-flex
Copy link
Collaborator

@yaugenst-flex yaugenst-flex commented Nov 13, 2025

Greptile Overview

Greptile Summary

This PR adds a new AGENTS.md documentation file that provides comprehensive guidelines for AI agents and human contributors working with the tidy3d repository. The guide covers:

  • First-time setup checklist with Poetry and pre-commit hooks
  • Project structure navigation and documentation standards
  • Development workflow using Poetry commands
  • Coding style conventions (snake_case, PascalCase, Tidy3dBaseModel usage)
  • Testing guidelines with pytest
  • Schema regeneration process
  • Commit and PR requirements including Conventional Commits and branch naming

The document serves as a centralized reference to help maintain consistency and quality across contributions.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a documentation-only addition that introduces a new AGENTS.md file with comprehensive repository guidelines. No code changes are involved, and the documentation appears well-structured and accurate based on the repository's existing configuration files
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
AGENTS.md 5/5 New documentation guide for AI agents and contributors with repository workflow, tooling, and coding standards

Sequence Diagram

sequenceDiagram
    participant Dev as Developer/Agent
    participant Repo as Repository
    participant Poetry as Poetry (Dependency Mgmt)
    participant PreCommit as Pre-commit Hooks
    participant CI as CI/CD System
    
    Note over Dev,CI: Initial Setup
    Dev->>Repo: Clone repository
    Dev->>Poetry: poetry install --with dev
    Poetry-->>Dev: Install dependencies
    Dev->>PreCommit: poetry run pre-commit install
    PreCommit-->>Dev: Enable hooks
    Dev->>PreCommit: poetry run pre-commit run --all-files
    PreCommit-->>Dev: Sync with hook set
    Dev->>Poetry: poetry run pytest
    Poetry-->>Dev: Validate environment
    
    Note over Dev,CI: Development Workflow
    Dev->>Repo: Read AGENTS.md guidelines
    Dev->>Repo: Make code changes
    Dev->>PreCommit: Commit (auto-run hooks)
    PreCommit->>PreCommit: Run ruff format, ruff check, doc hooks
    PreCommit-->>Dev: Validation result
    Dev->>Poetry: poetry run pytest
    Poetry-->>Dev: Test results
    Dev->>PreCommit: poetry run pre-commit run --all-files
    PreCommit-->>Dev: Final validation
    
    Note over Dev,CI: Schema Updates (if needed)
    Dev->>Poetry: poetry run python scripts/regenerate_schema.py
    Poetry-->>Dev: Generate schema artifacts
    Dev->>Repo: Commit schema changes
    
    Note over Dev,CI: Pull Request
    Dev->>Repo: Create PR (Conventional Commit + Jira key)
    Repo->>CI: Trigger CI checks
    CI->>CI: Run pytest, pre-commit, schema validation
    CI-->>Repo: CI status
    Repo-->>Dev: PR ready for review
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@marcorudolphflex
Copy link
Contributor

marcorudolphflex commented Nov 13, 2025

Have you made a quick test from a fresh repo with this agents.md which covers a task that relate to the instructions?

@yaugenst-flex
Copy link
Collaborator Author

Have you made a quick test from a fresh repo with this agents.md which covers a task that relate to the instructions?

i've been using variations of this file for a while :D i think it works well, but definitely makes sense to interate a bit. we should also just keep the instructions updated if anything doesnt seem to work well

@yaugenst-flex yaugenst-flex force-pushed the FXC-4077-agents-md-for-tidy-3-d-python-client-root branch from 827d66e to f73075d Compare November 14, 2025 08:22
@yaugenst-flex yaugenst-flex force-pushed the FXC-4077-agents-md-for-tidy-3-d-python-client-root branch from f73075d to 49eb604 Compare November 14, 2025 08:22
@yaugenst-flex
Copy link
Collaborator Author

ok i think this is pretty safe to merge, we'll need to iterate on the instructions anyways if something feels off

@yaugenst-flex
Copy link
Collaborator Author

@daquinteroflex i also snuck in an update to the readme badges

@yaugenst-flex yaugenst-flex added this pull request to the merge queue Nov 14, 2025
Merged via the queue into develop with commit 427dec9 Nov 14, 2025
26 checks passed
@yaugenst-flex yaugenst-flex deleted the FXC-4077-agents-md-for-tidy-3-d-python-client-root branch November 14, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants