Skip to content

Conversation

@daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Nov 17, 2025

Required because full dev installation is consuming too much memory of the runners and sometimes they error

Greptile Summary

  • Adds tests extras group to pyproject.toml with 11 test-related dependencies
  • Enables lighter installations for test environments without requiring all dev dependencies

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Simple, well-structured dependency reorganization with no code changes, only configuration updates that follow poetry's standard practices
  • No files require special attention

Important Files Changed

Filename Overview
pyproject.toml Introduces new tests extras group with 11 testing-related dependencies to enable lighter installations without full dev dependencies

Sequence Diagram

sequenceDiagram
    participant User
    participant pip
    participant pyproject.toml
    participant poetry
    
    User->>pip: pip install tidy3d[tests]
    pip->>pyproject.toml: Read extras configuration
    pyproject.toml-->>pip: Return tests dependencies list
    pip->>poetry: Resolve dependency markers
    poetry-->>pip: Provide resolved packages
    pip->>User: Install lightweight test environment
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@daquinteroflex daquinteroflex changed the title chore: introduce tests extras for lighter install chore: introduce tests extras for lighter install (FXC-4160) Nov 17, 2025
@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@daquinteroflex daquinteroflex added this pull request to the merge queue Nov 17, 2025
Merged via the queue into develop with commit 3797b69 Nov 17, 2025
63 of 69 checks passed
@daquinteroflex daquinteroflex deleted the dario/tests branch November 17, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants