Skip to content

Conversation

@daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Nov 26, 2025

Remove on push trigger of the python client

Greptile Overview

Greptile Summary

Removed the on.push trigger for develop and latest branches from the develop-CLI workflow. This change reduces unnecessary CI runs, as the workflow is already invoked by the main test workflow when needed via workflow_call, runs daily via schedule, and can be manually triggered via workflow_dispatch.

  • Workflow still runs on schedule (daily at 2:00 AM UTC)
  • Can still be manually triggered via workflow_dispatch
  • Still callable by other workflows (e.g., tidy3d-python-client-tests.yml)
  • Reduces redundant CI execution on every push to develop/latest branches

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change only removes a trigger from a CI workflow without affecting any logic or functionality. The workflow remains accessible through three other mechanisms (scheduled runs, manual dispatch, and workflow_call from other workflows), ensuring no loss of functionality while reducing unnecessary CI runs.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/tidy3d-python-client-develop-cli.yml 5/5 Removed push trigger for develop and latest branches; workflow now only runs on schedule, manual dispatch, or when called by other workflows

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant MainTests as python-client-tests.yml
    participant CLIWorkflow as develop-cli.yml
    participant Scheduler as Cron Scheduler

    Note over Dev,Scheduler: Before This PR
    Dev->>GH: Push to develop/latest
    GH->>CLIWorkflow: Trigger on push
    CLIWorkflow->>CLIWorkflow: Run CLI tests

    Note over Dev,Scheduler: After This PR
    Dev->>GH: Push to develop/latest
    Note over GH,CLIWorkflow: No automatic trigger

    Note over Dev,Scheduler: Workflow Still Accessible Via:
    
    Scheduler->>CLIWorkflow: Daily cron (2:00 AM UTC)
    CLIWorkflow->>CLIWorkflow: Run CLI tests
    
    Dev->>GH: Manual workflow_dispatch
    GH->>CLIWorkflow: Trigger manually
    CLIWorkflow->>CLIWorkflow: Run CLI tests
    
    MainTests->>CLIWorkflow: workflow_call (when cli_tests=true)
    CLIWorkflow->>CLIWorkflow: Run CLI tests
    CLIWorkflow->>MainTests: Return success status
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@daquinteroflex daquinteroflex changed the title ci: remove push based trigger (FXC-4061) ci: develop remove push based trigger (FXC-4061) Nov 26, 2025
@daquinteroflex daquinteroflex changed the title ci: develop remove push based trigger (FXC-4061) ci: develop-cli tests remove push based trigger (FXC-4061) Nov 26, 2025
@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@daquinteroflex daquinteroflex added this pull request to the merge queue Nov 26, 2025
Merged via the queue into develop with commit 4728548 Nov 26, 2025
95 of 104 checks passed
@daquinteroflex daquinteroflex deleted the dario/remove_dev_cli branch November 26, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants