ci: develop-cli tests remove push based trigger (FXC-4061) #3033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove on push trigger of the python client
Greptile Overview
Greptile Summary
Removed the
on.pushtrigger fordevelopandlatestbranches from the develop-CLI workflow. This change reduces unnecessary CI runs, as the workflow is already invoked by the main test workflow when needed viaworkflow_call, runs daily viaschedule, and can be manually triggered viaworkflow_dispatch.tidy3d-python-client-tests.yml)Confidence Score: 5/5
Important Files Changed
File Analysis
developandlatestbranches; workflow now only runs on schedule, manual dispatch, or when called by other workflowsSequence Diagram
sequenceDiagram participant Dev as Developer participant GH as GitHub participant MainTests as python-client-tests.yml participant CLIWorkflow as develop-cli.yml participant Scheduler as Cron Scheduler Note over Dev,Scheduler: Before This PR Dev->>GH: Push to develop/latest GH->>CLIWorkflow: Trigger on push CLIWorkflow->>CLIWorkflow: Run CLI tests Note over Dev,Scheduler: After This PR Dev->>GH: Push to develop/latest Note over GH,CLIWorkflow: No automatic trigger Note over Dev,Scheduler: Workflow Still Accessible Via: Scheduler->>CLIWorkflow: Daily cron (2:00 AM UTC) CLIWorkflow->>CLIWorkflow: Run CLI tests Dev->>GH: Manual workflow_dispatch GH->>CLIWorkflow: Trigger manually CLIWorkflow->>CLIWorkflow: Run CLI tests MainTests->>CLIWorkflow: workflow_call (when cli_tests=true) CLIWorkflow->>CLIWorkflow: Run CLI tests CLIWorkflow->>MainTests: Return success status