fix: autorelease secret inheritance (FXC-3911) #3039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Added
secrets: inheritdirective to therun-client-testsjob call in the release workflow. This enables the reusable test workflow to access required secrets (GITHUB_TOKENfor git operations andGH_TIDY3D_COVERAGE_GISTfor coverage reporting) that were previously unavailable.Changes:
secrets: inheritwith zizmor ignore directive at line 403create-tagat line 383,sync-readthedocsat line 470)Confidence Score: 5/5
secrets: inheritdirective is already used in two other reusable workflow calls (create-tag and sync-readthedocs), and this change simply applies the same pattern to run-client-tests. The zizmor ignore directive indicates proper security review acknowledgment. No logic changes, no new functionality - just enabling required secret access for an existing workflowImportant Files Changed
File Analysis
secrets: inherittorun-client-testsjob call with zizmor ignore directive - enables required secret propagation to reusable workflowSequence Diagram
sequenceDiagram participant Trigger as Release Workflow participant Scope as determine-workflow-scope participant Tag as create-tag participant Tests as run-client-tests participant Compile as compile-tests-results participant Deploy as Deploy Jobs Trigger->>Scope: Start workflow with release_tag Scope->>Scope: Determine test/deploy scope Scope-->>Tag: run_tag=true Scope-->>Tests: run_client_tests=true Note over Tag: Uses secrets: inherit<br/>(GH_PAT) Tag->>Tag: Create and push git tag Note over Tests: NEW: secrets: inherit<br/>(GITHUB_TOKEN, GH_TIDY3D_COVERAGE_GIST) Tests->>Tests: Run local/remote/CLI/submodule tests Tests->>Tests: Access GITHUB_TOKEN for git operations Tests->>Tests: Access GH_TIDY3D_COVERAGE_GIST for coverage Tests-->>Compile: workflow_success output Compile->>Compile: Validate all test results Compile-->>Deploy: proceed_deploy=true Note over Deploy: Continue with deployment<br/>if tests pass