Skip to content

Conversation

@daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Nov 26, 2025

Greptile Overview

Greptile Summary

Added secrets: inherit directive to the run-client-tests job call in the release workflow. This enables the reusable test workflow to access required secrets (GITHUB_TOKEN for git operations and GH_TIDY3D_COVERAGE_GIST for coverage reporting) that were previously unavailable.

Changes:

  • Added secrets: inherit with zizmor ignore directive at line 403
  • Follows same pattern as other reusable workflow calls (create-tag at line 383, sync-readthedocs at line 470)
  • Resolves FXC-3911 where tests were failing due to missing secret access

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a straightforward one-line addition that follows established patterns in the same file. The secrets: inherit directive is already used in two other reusable workflow calls (create-tag and sync-readthedocs), and this change simply applies the same pattern to run-client-tests. The zizmor ignore directive indicates proper security review acknowledgment. No logic changes, no new functionality - just enabling required secret access for an existing workflow
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/tidy3d-python-client-release.yml 5/5 Added secrets: inherit to run-client-tests job call with zizmor ignore directive - enables required secret propagation to reusable workflow

Sequence Diagram

sequenceDiagram
    participant Trigger as Release Workflow
    participant Scope as determine-workflow-scope
    participant Tag as create-tag
    participant Tests as run-client-tests
    participant Compile as compile-tests-results
    participant Deploy as Deploy Jobs

    Trigger->>Scope: Start workflow with release_tag
    Scope->>Scope: Determine test/deploy scope
    Scope-->>Tag: run_tag=true
    Scope-->>Tests: run_client_tests=true
    
    Note over Tag: Uses secrets: inherit<br/>(GH_PAT)
    Tag->>Tag: Create and push git tag
    
    Note over Tests: NEW: secrets: inherit<br/>(GITHUB_TOKEN, GH_TIDY3D_COVERAGE_GIST)
    Tests->>Tests: Run local/remote/CLI/submodule tests
    Tests->>Tests: Access GITHUB_TOKEN for git operations
    Tests->>Tests: Access GH_TIDY3D_COVERAGE_GIST for coverage
    Tests-->>Compile: workflow_success output
    
    Compile->>Compile: Validate all test results
    Compile-->>Deploy: proceed_deploy=true
    
    Note over Deploy: Continue with deployment<br/>if tests pass
Loading

@daquinteroflex daquinteroflex marked this pull request as ready for review November 26, 2025 14:24
@daquinteroflex daquinteroflex merged commit 8e7ff17 into develop Nov 26, 2025
29 of 31 checks passed
@daquinteroflex daquinteroflex deleted the dario/fix_autorelease_secrets_inheritance branch November 26, 2025 14:26
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants