Skip to content

save and load None in hdf5 files #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

save and load None in hdf5 files #488

merged 1 commit into from
Aug 30, 2022

Conversation

@tylerflex
Copy link
Collaborator

@tylerflex tylerflex commented Aug 30, 2022 •
edited
Loading

if value is None when packing dataset, save as np.nan. If np.nan encountered in hdf5 file, load as None.

@tylerflex tylerflex requested a review from momchil-flex August 30, 2022 08:37
@tylerflex tylerflex added the 1.6 label Aug 30, 2022
@momchil-flex momchil-flex merged commit 93ec431 into develop Aug 30, 2022
@momchil-flex momchil-flex deleted the feature/save_none_properly branch August 30, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@momchil-flex momchil-flex Awaiting requested review from momchil-flex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylerflex @momchil-flex