Skip to content

Fill out some utility functions for non-open kwarg graphs#1648

Merged
lockshaw merged 2 commits into
flexflow:masterfrom
lockshaw:closed-kwarg-graph-funcs
Jun 2, 2026
Merged

Fill out some utility functions for non-open kwarg graphs#1648
lockshaw merged 2 commits into
flexflow:masterfrom
lockshaw:closed-kwarg-graph-funcs

Conversation

@lockshaw
Copy link
Copy Markdown
Collaborator

@lockshaw lockshaw commented Jun 2, 2026

Description of changes:

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

@lockshaw lockshaw requested a review from elliottslaughter June 2, 2026 05:40
Copy link
Copy Markdown
Collaborator

@elliottslaughter elliottslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elliottslaughter reviewed 22 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on lockshaw).


lib/utils/include/utils/graph/kwarg_dataflow_graph/algorithms/dataflow_graph_data_from_kwarg_dataflow_graph_data.h line 10 at r1 (raw file):

#include "utils/graph/dataflow_graph/algorithms/dataflow_graph_data.dtg.h"
#include "utils/graph/kwarg_dataflow_graph/algorithms/kwarg_dataflow_graph_data.dtg.h"
#include "utils/nonempty_unordered_set/nonempty_unordered_set.h"

You're removing this include but it looks like you actually do use it in the new code below.

@lockshaw lockshaw force-pushed the closed-kwarg-graph-funcs branch from 09e99c2 to 1ff30c2 Compare June 2, 2026 23:02
@lockshaw lockshaw merged commit 785d403 into flexflow:master Jun 2, 2026
2 of 3 checks passed
@lockshaw lockshaw deleted the closed-kwarg-graph-funcs branch June 2, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants