This repository was archived by the owner on Jun 13, 2022. It is now read-only.
Changing redirectHost and redirectUrl in the SMART auth module#93
Closed
mseckykoebel wants to merge 11 commits intomasterfrom
Closed
Changing redirectHost and redirectUrl in the SMART auth module#93mseckykoebel wants to merge 11 commits intomasterfrom
mseckykoebel wants to merge 11 commits intomasterfrom
Conversation
…d the redirectPath
Contributor
Author
|
There's a SMART auth test that's failing, which I need to fix to match the changes made in this PR. |
…the tests do not fail
Contributor
Author
|
Closing this and replacing it with #93. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the comments in #92, which changes the redirectHost property of the
SmartAuthProviderto be mandatory, and changes the value of the reditectUrl.