feat(i18n): add spanish localization#182
Conversation
* Add files via upload * Update 260529c_es.json Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update 260529c_es.json Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Add messages for Winget and Chocolatey availability The two missing strings have been translated --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Spanish language support ("Español") to both the app and the website by updating Astro configurations, adding a Spanish flag SVG, providing translation files, and registering the language in MainPage.astro. Feedback points out that the flag code used for Spain (1f1ea-1f1e6) is incorrect and should be updated to 1f1ea-1f1f8 to avoid displaying the flag for Ceuta & Melilla.
| { | ||
| name: "Español", | ||
| code: "es", | ||
| flagCode: "1f1ea-1f1e6", | ||
| translator: "dracp", | ||
| translatorUrl: "https://github.com/dracp", | ||
| }, |
There was a problem hiding this comment.
The flag code for Spain (ES) is 1f1ea-1f1f8 (E = 1f1ea, S = 1f1f8). The current code uses 1f1ea-1f1e6 (EA), which represents Ceuta & Melilla.
{
name: "Español",
code: "es",
flagCode: "1f1ea-1f1f8",
translator: "dracp",
translatorUrl: "https://github.com/dracp",
},
| { | ||
| name: "Español", | ||
| code: "es", | ||
| flagCode: "1f1ea-1f1e6", | ||
| translator: "dracp", | ||
| translatorUrl: "https://github.com/dracp", | ||
| }, |
There was a problem hiding this comment.
The flag code for Spain (ES) is 1f1ea-1f1f8 (E = 1f1ea, S = 1f1f8). The current code uses 1f1ea-1f1e6 (EA), which represents Ceuta & Melilla. This will cause the wrong flag to be fetched from the twemoji CDN.
{
name: "Español",
code: "es",
flagCode: "1f1ea-1f1f8",
translator: "dracp",
translatorUrl: "https://github.com/dracp",
},
There was a problem hiding this comment.
The flag code for Spain (ES) is
1f1ea-1f1f8(E =1f1ea, S =1f1f8). The current code uses1f1ea-1f1e6(EA), which represents Ceuta & Melilla. This will cause the wrong flag to be fetched from the twemoji CDN.{ name: "Español", code: "es", flagCode: "1f1ea-1f1f8", translator: "dracp", translatorUrl: "https://github.com/dracp", },
If you wouldn't mind, could you please list the translator as Damián Roig? Thanks.
2 participants
No description provided.