feat(i18n): add vietnamese localization#195
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds Vietnamese language support (vi) to both the app and the website, including Astro configuration updates, a new flag icon, and translation files. The reviewer identified a minor inconsistency in both vi.json files where trailing periods were included in the titles for iexplorer, faxscan, and mediaplayer, and suggested removing them to maintain consistency with other titles.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "debloat.features.iexplorer": "Tắt Internet Explorer.", | ||
| "debloat.features.faxscan": "Tắt Fax và Scan.", | ||
| "debloat.features.mediaplayer": "Tắt Media Player.", |
There was a problem hiding this comment.
The title keys for iexplorer, faxscan, and mediaplayer have trailing periods, which is inconsistent with all other title keys in the localization file (which do not end with a period). Please remove the trailing periods to maintain consistency.
| "debloat.features.iexplorer": "Tắt Internet Explorer.", | |
| "debloat.features.faxscan": "Tắt Fax và Scan.", | |
| "debloat.features.mediaplayer": "Tắt Media Player.", | |
| "debloat.features.iexplorer": "Tắt Internet Explorer", | |
| "debloat.features.faxscan": "Tắt Fax và Scan", | |
| "debloat.features.mediaplayer": "Tắt Media Player", |
| "debloat.features.iexplorer": "Tắt Internet Explorer.", | ||
| "debloat.features.faxscan": "Tắt Fax và Scan.", | ||
| "debloat.features.mediaplayer": "Tắt Media Player.", |
There was a problem hiding this comment.
The title keys for iexplorer, faxscan, and mediaplayer have trailing periods, which is inconsistent with all other title keys in the localization file (which do not end with a period). Please remove the trailing periods to maintain consistency.
| "debloat.features.iexplorer": "Tắt Internet Explorer.", | |
| "debloat.features.faxscan": "Tắt Fax và Scan.", | |
| "debloat.features.mediaplayer": "Tắt Media Player.", | |
| "debloat.features.iexplorer": "Tắt Internet Explorer", | |
| "debloat.features.faxscan": "Tắt Fax và Scan", | |
| "debloat.features.mediaplayer": "Tắt Media Player", |
Deploying winscript with
|
| Latest commit: |
6d3d26f
|
| Status: | ⚡️ Build in progress... |
2 participants
No description provided.