Add Grid to the postcss config for autoprefixer#1
Merged
nomad-mystic merged 1 commit intomasterfrom Oct 28, 2019
Merged
Conversation
Member
|
@nomad-mystic i'm not familiar with that config option, what does it do? |
Contributor
Author
|
It adds -ms- prefixes to grid properties and changes the properties to match something IE understands. grid-template-columns = -ms-grid-columns I found that you have to explicitly say you want to have Autoprefixer prefix grid. I found the option here: https://css-tricks.com/css-grid-in-ie-css-grid-and-the-new-autoprefixer/ Keith |
Member
|
awesome - sounds good |
codyrobert
approved these changes
Oct 28, 2019
chrislarrycarl
approved these changes
Oct 28, 2019
Contributor
chrislarrycarl
left a comment
There was a problem hiding this comment.
Thanks for the extra details @nomad-mystic, it helps provide context for the review and will serve as good reference if/when we need to refer back to this.
We will also want to get this change added to our 2.0 branch so we can ensure parity for future builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned out a couple .DS_stores, ticked up the version number, and added grid to the Autoprefixer config for PostCSS to pick up.