Skip to content

Add Grid to the postcss config for autoprefixer#1

Merged
nomad-mystic merged 1 commit intomasterfrom
km-add-grid-autoprefixer
Oct 28, 2019
Merged

Add Grid to the postcss config for autoprefixer#1
nomad-mystic merged 1 commit intomasterfrom
km-add-grid-autoprefixer

Conversation

@nomad-mystic
Copy link
Contributor

Cleaned out a couple .DS_stores, ticked up the version number, and added grid to the Autoprefixer config for PostCSS to pick up.

@codyrobert
Copy link
Member

@nomad-mystic i'm not familiar with that config option, what does it do?

@nomad-mystic
Copy link
Contributor Author

@codyrobert

It adds -ms- prefixes to grid properties and changes the properties to match something IE understands.

grid-template-columns = -ms-grid-columns
grid-column = -ms-grid-column

I found that you have to explicitly say you want to have Autoprefixer prefix grid. I found the option here: https://css-tricks.com/css-grid-in-ie-css-grid-and-the-new-autoprefixer/

Keith

@codyrobert
Copy link
Member

awesome - sounds good

Copy link
Contributor

@chrislarrycarl chrislarrycarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra details @nomad-mystic, it helps provide context for the review and will serve as good reference if/when we need to refer back to this.

We will also want to get this change added to our 2.0 branch so we can ensure parity for future builds.

@nomad-mystic nomad-mystic merged commit df1fe13 into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants