Merged
Conversation
mutability
requested changes
Apr 2, 2026
Contributor
mutability
left a comment
mutability
left a comment
There was a problem hiding this comment.
If 1.7 and 1.8 have mutually-exclusive option support, then a polyfill wrapper is probably the better approach rather than version checks at every point of use
mutability
reviewed
Apr 2, 2026
The 1.8 default validation logic looks sufficent, so avoid -validatecommand entirely (since it'll break 1.7) Server-side supports TLS1.3, and all supported client package versions depend on a sufficently-new tcltls to have TLS1.3, so just support TLS1.3 only and disable everything else.
… only As with piaware, but this time on the server side. Support TLS 1.3 only. pirehose is for ad-hoc experimentation with a firehose-ish interface, so it's reasonable to expect clients to have 1.3 support, I think..
With debugTLS = 0 (the default): log TLS alerts only With debugTLS = 1: log all TLS info tracing With debugTLS = 2: log all TLS info tracing and all TLS message tracing
This lets you set debugTLS in fa_adept_client instances
Contributor
|
I've pushed changes that I think mostly address my review comments. This appears to work as expected on trixie (with tcltls 1.8.0-2), but I have not tested against bullseye/bookworm (which will have 1.7.22). We should retest against those. |
mutability
approved these changes
Apr 7, 2026
|
The only issue I see is by removing use of -validatecommand, you won't log certificate errors. Not sure if that's important to you or not. The user will get a connect error since the validation will fail, so ultimately they will know why. |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR based on #120 with minor bug fixes.