Merged
Conversation
While we had been trying to fit Map's semantics into JSON's object,
the solution had been in front of us all along: It's impossible!
`new Map()` takes a list of pairs and not an object, because objects are inherently
less powerful than Maps.
By also using list of pairs to describe `Map`, we finally can serialize
`Map<RegExp, V>` or `Map<{}, V>`.
See introduced tests in `index.test.ts` for reference! :D
Skn0tt
changed the title
Map using a list of pairs
Merged
merelinguist
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33, #35
While we had been trying to fit Map's semantics into JSON's object, the solution had been in front of us all along: It's impossible!
That's why
new Map(...)takes a list of pairs instead of an object.This PR suggests to also use a list of pairs to serialize
Map, which allows us to distinguish different objects from one another and also support non-primitive values.This PR may be a bit hard to comprehend, so please go forward and ask all the questions you like ^^