EDM-259: Unify form labels format#289
Merged
Merged
Conversation
|
""" WalkthroughThis change updates user-facing labels and accessibility attributes in English locale files and UI components. The labels "Alias" and "Name" are replaced with the more specific "Device alias" and "Fleet name" in both display text and ARIA attributes. A corresponding translation key is added to the English locale JSON. Additionally, a Cypress test selector was updated to reflect the new "Fleet name" aria-label. Changes
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
celdrake
force-pushed
the
EDM-259-unify-form-label-format
branch
from
d90251b to
e39c4a3
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/cypress/pages/CreateFleetWizardPage.ts (1)
22-24: Missing closing bracket in aria-label selector.This isn't related to the current PR, but there's a syntax error in the selector - the aria-label attribute is missing its closing bracket.
- return cy.get('button[aria-label="Validation"').click(); + return cy.get('button[aria-label="Validation"]').click();
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
libs/cypress/pages/CreateFleetWizardPage.ts(1 hunks)libs/i18n/locales/en/translation.json(1 hunks)libs/ui-components/src/components/Device/EditDeviceWizard/steps/GeneralInfoStep.tsx(1 hunks)libs/ui-components/src/components/Device/EditDeviceWizard/steps/ReviewDeviceStep.tsx(1 hunks)libs/ui-components/src/components/Fleet/CreateFleet/steps/GeneralInfoStep.tsx(1 hunks)libs/ui-components/src/components/Fleet/CreateFleet/steps/ReviewStep.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- libs/ui-components/src/components/Device/EditDeviceWizard/steps/ReviewDeviceStep.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
- libs/ui-components/src/components/Device/EditDeviceWizard/steps/GeneralInfoStep.tsx
- libs/ui-components/src/components/Fleet/CreateFleet/steps/GeneralInfoStep.tsx
- libs/ui-components/src/components/Fleet/CreateFleet/steps/ReviewStep.tsx
- libs/i18n/locales/en/translation.json
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: integration-tests
- GitHub Check: Build ocp plugin
- GitHub Check: Lint
- GitHub Check: Build
🔇 Additional comments (1)
libs/cypress/pages/CreateFleetWizardPage.ts (1)
18-20: LGTM! This change aligns with the PR objective.The updated selector correctly uses the more specific "Fleet name" aria-label instead of the generic "Name", which maintains consistency with the updated UI components. This change supports the standardization of form labels to include resource kind prefixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the format for name/alias fields so that it's always prefixed by the resource king (eg. Device alias, Fleet name)
Summary by CodeRabbit
New Features
Style