Skip to content

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Dec 2, 2025

The role names have changed from admin to flightctl-admin etc.

Summary by CodeRabbit

  • Updates
    • Updated role naming examples to use "flightctl-" prefix format in helper text
    • Revised role separator configuration examples and descriptions
    • Removed edit affordance from role assignment labels, preserving delete functionality

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Warning

Rate limit exceeded

@celdrake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 617cf05 and 7c1c641.

📒 Files selected for processing (3)
  • libs/i18n/locales/en/translation.json (1 hunks)
  • libs/ui-components/src/components/AuthProvider/CreateAuthProvider/AuthProviderHelperText.tsx (1 hunks)
  • libs/ui-components/src/components/AuthProvider/CreateAuthProvider/RoleAssignmentSection.tsx (2 hunks)

Walkthrough

Role naming conventions updated from generic names (e.g., "admin") to flightctl-prefixed variants (e.g., "flightctl-admin") across translation files, helper text, and role assignment logic. The UI also removes the isEditable prop from role label components.

Changes

Cohort / File(s) Summary
Translation and Helper Text Updates
libs/i18n/locales/en/translation.json, libs/ui-components/src/components/AuthProvider/CreateAuthProvider/AuthProviderHelperText.tsx
Updated example text in role separator explanation from "org1:admin" to "org1:flightctl-admin", with corresponding global role examples changed from "admin" to "flightctl-admin"
Role Assignment Logic
libs/ui-components/src/components/AuthProvider/CreateAuthProvider/RoleAssignmentSection.tsx
Internal role mapping keys changed from generic names to flightctl-prefixed variants (e.g., "admin" → "flightctl-admin"). Removed isEditable prop from Label components in the role list

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Role mapping updates: Straightforward key renaming following a consistent pattern across all role types
  • Helper text alignment: Simple example text updates with no behavioral changes
  • UI prop removal: Single, isolated change with no logic implications

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'EDM-2705: Fix auth provider roles to new names' directly matches the main changeset, which updates role names from generic variants to flightctl-prefixed variants across three files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake requested a review from asafbennatan December 2, 2025 09:04
@celdrake celdrake force-pushed the EDM-2705-fix-auth-provider-roles branch from 617cf05 to 7c1c641 Compare December 3, 2025 10:27
@celdrake celdrake merged commit 251e60a into flightctl:main Dec 3, 2025
6 checks passed
@celdrake celdrake deleted the EDM-2705-fix-auth-provider-roles branch December 3, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants