Skip to content

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Dec 19, 2025

Yet to be done: review if the YAML editor is aligned with newer versions.

@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025

Important

Review skipped

Too many files!

7 files out of 157 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the upgrade-pf6 branch 2 times, most recently from f2249ee to 516834a Compare December 19, 2025 17:03
@celdrake celdrake marked this pull request as ready for review December 23, 2025 13:44
@celdrake celdrake changed the title WIP: Upgrade pf6 Upgrade to Patternfly v6 Dec 23, 2025
@celdrake celdrake changed the title Upgrade to Patternfly v6 EDM-2865: Upgrade to Patternfly v6 Dec 30, 2025
Copy link
Collaborator

@jgyselov jgyselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one potential little problem. 🙂

As for the PF6 updates, I didn't see any issues in the code or the UI (the parts that I managed to interact with).

@celdrake
Copy link
Collaborator Author

Just one potential little problem. 🙂

As for the PF6 updates, I didn't see any issues in the code or the UI (the parts that I managed to interact with).

Great, thanks!

The "Devices" area is a bit tricker to test because you need to either enroll a device (it can be done easily in the backend project doing make agent-vm, but it's a bit slow), or simulate one (but then you can't have the device change its status, etc).

Let me know if you'd want to proceed further or you're satisfied with what you covered.

@jgyselov
Copy link
Collaborator

Just one potential little problem. 🙂
As for the PF6 updates, I didn't see any issues in the code or the UI (the parts that I managed to interact with).

Great, thanks!

The "Devices" area is a bit tricker to test because you need to either enroll a device (it can be done easily in the backend project doing make agent-vm, but it's a bit slow), or simulate one (but then you can't have the device change its status, etc).

Let me know if you'd want to proceed further or you're satisfied with what you covered.

I managed to simulate a fleet so I could see the tables, the detail pages, and the edit forms etc. It all looked fine and the changes in the code weren't complicated anyway. I think you're good here.

@celdrake
Copy link
Collaborator Author

@jgyselov I fixed the CPU validation issue, rebased to latest "main" (and adapted the new LoginCommand component to PF6).
IMO this should be good now, could you please take a final look?

@celdrake celdrake merged commit 293dd50 into flightctl:main Jan 14, 2026
6 checks passed
@celdrake celdrake deleted the upgrade-pf6 branch January 14, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants