-
Notifications
You must be signed in to change notification settings - Fork 17
EDM-2865: Upgrade to Patternfly v6 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedToo many files! 7 files out of 157 files are above the max files limit of 150. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
libs/ui-components/src/components/AuthProvider/AuthProviderDetails/RoleAssigmentDetails.tsx
Show resolved
Hide resolved
f2249ee to
516834a
Compare
jgyselov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one potential little problem. 🙂
As for the PF6 updates, I didn't see any issues in the code or the UI (the parts that I managed to interact with).
Great, thanks! The "Devices" area is a bit tricker to test because you need to either enroll a device (it can be done easily in the backend project doing Let me know if you'd want to proceed further or you're satisfied with what you covered. |
I managed to simulate a fleet so I could see the tables, the detail pages, and the edit forms etc. It all looked fine and the changes in the code weren't complicated anyway. I think you're good here. |
|
@jgyselov I fixed the CPU validation issue, rebased to latest "main" (and adapted the new LoginCommand component to PF6). |
Yet to be done: review if the YAML editor is aligned with newer versions.