Skip to content

Update minimatch#552

Merged
celdrake merged 3 commits intoflightctl:mainfrom
celdrake:update-minimatch
Mar 4, 2026
Merged

Update minimatch#552
celdrake merged 3 commits intoflightctl:mainfrom
celdrake:update-minimatch

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Mar 3, 2026

Update minimatch to prevent issues

https://github.com/flightctl/flightctl-ui/security/dependabot/85

https://github.com/flightctl/flightctl-ui/security/dependabot/87

https://github.com/flightctl/flightctl-ui/security/dependabot/88

https://github.com/flightctl/flightctl-ui/security/dependabot/89

  • Required updating @typescript-eslint related packages as they were using the unpatched v9.0.x minimatch version.
  • Now all dependencies are either v9.0.9 or v3.1.5

Summary by CodeRabbit

  • Chores
    • Updated dependencies and development tooling, including Formik and ESLint-related packages.
  • Refactor
    • Internal form array handling in several UI components was modernized to a consistent helper pattern; no user-facing behavior changes.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Warning

Rate limit exceeded

@celdrake has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60212b48-d61f-40ee-b227-d130a7f9afc0

📥 Commits

Reviewing files that changed from the base of the PR and between af06e33 and ade498b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (12)
  • apps/ocp-plugin/package.json
  • libs/ui-components/package.json
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationHelmForm.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationInlineForm.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationTemplates.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationVariablesForm.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationVolumeForm.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ConfigInlineTemplateForm.tsx
  • libs/ui-components/src/components/Device/EditDeviceWizard/steps/ConfigurationTemplates.tsx
  • libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdateStepRolloutPolicy.tsx
  • libs/ui-components/src/components/Repository/CreateRepository/CreateResourceSyncsForm.tsx
  • package.json

Walkthrough

Refactors Formik FieldArray render-prop usage across multiple form components to receive a single arrayHelpers parameter instead of destructured { push, remove }, and updates dependency versions (formik and several dev eslint/typescript-eslint packages).

Changes

Cohort / File(s) Summary
Dependency Updates
apps/ocp-plugin/package.json, package.json, libs/ui-components/package.json
Bumped formik from ^2.4.5^2.4.9; upgraded dev tooling versions (@typescript-eslint/eslint-plugin, @typescript-eslint/parser, eslint); added @types/semver to libs/ui-components devDependencies.
FieldArray Refactoring (Device: EditDeviceWizard)
libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationHelmForm.tsx, libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationInlineForm.tsx, libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationTemplates.tsx, libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationVariablesForm.tsx, libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationVolumeForm.tsx
Changed FieldArray render-prop signature from destructured { push, remove } to a single (arrayHelpers) parameter; replaced push(...)/remove(...) calls with arrayHelpers.push(...)/arrayHelpers.remove(...). Added mountPath: '' when pushing new volumes in ApplicationVolumeForm.
FieldArray Refactoring (Config / Templates)
libs/ui-components/src/components/Device/EditDeviceWizard/steps/ConfigInlineTemplateForm.tsx, libs/ui-components/src/components/Device/EditDeviceWizard/steps/ConfigurationTemplates.tsx
Same FieldArray signature change and call updates from push/remove to arrayHelpers.push/remove for inline templates and configuration templates.
FieldArray Refactoring (Fleet / Repository forms)
libs/ui-components/src/components/Fleet/CreateFleet/steps/UpdateStepRolloutPolicy.tsx, libs/ui-components/src/components/Repository/CreateRepository/CreateResourceSyncsForm.tsx
Updated FieldArray render-prop to accept arrayHelpers and replaced push/remove usages with arrayHelpers.push/remove in rollout policy and resource syncs forms.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update minimatch' is vague and does not clearly convey the full scope of the changes, which include updating formik, @typescript-eslint packages, and @types/semver in addition to minimatch. Consider a more descriptive title that reflects the main objective, such as 'Update minimatch and related dependencies for security' or 'Bump minimatch, eslint, and formik versions'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the update-minimatch branch 3 times, most recently from ae7650a to af06e33 Compare March 4, 2026 08:26
@celdrake celdrake merged commit 06b11e2 into flightctl:main Mar 4, 2026
6 checks passed
@celdrake celdrake deleted the update-minimatch branch March 4, 2026 08:55
celdrake added a commit to celdrake/flightctl-ui that referenced this pull request Mar 4, 2026
* Update eslint dependencies
* Update formik to v2.4.9
* Update minimatch

(cherry picked from commit 06b11e2)
celdrake added a commit that referenced this pull request Mar 4, 2026
* Update package-lock.json and systeminformation (#538)

(cherry picked from commit e6c00fb)

* Update ajv to v8.18.0 / v6.14.0 (#546)

(cherry picked from commit 0409eda)

* Update minimatch (#552)

* Update eslint dependencies
* Update formik to v2.4.9
* Update minimatch

(cherry picked from commit 06b11e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants