Skip to content

EDM-1024: Use generic implementations for common store methods#755

Merged
avishayt merged 2 commits intoflightctl:mainfrom
avishayt:initial-generics
Jan 22, 2025
Merged

EDM-1024: Use generic implementations for common store methods#755
avishayt merged 2 commits intoflightctl:mainfrom
avishayt:initial-generics

Conversation

@avishayt
Copy link
Copy Markdown
Collaborator

@avishayt avishayt commented Jan 2, 2025

Use generics for device and fleet stores, for create, update, get, and delete. Will expand to all methods of all stores.

Summary by CodeRabbit

Release Notes

New Features

  • Enhanced generic store pattern for more modular and consistent resource management.
  • Improved error handling and validation across various resource types.
  • Added new methods for resource specification and status management, including InitialMigration for various interfaces.

Improvements

  • Standardized callback mechanisms with organization context.
  • Updated method signatures to provide more detailed state transitions.
  • Refined resource conversion and API interaction methods, now returning pointers and errors.

Changes

  • Migrated from model-based to API-based resource representations.
  • Introduced additional parameters for more granular resource updates.
  • Simplified resource store implementations using the generic store pattern.

Bug Fixes

  • Improved handling of resource creation, update, and deletion scenarios.
  • Enhanced error tracking and logging for resource operations.

Refactoring

  • Consolidated resource management logic.
  • Removed redundant code and simplified method implementations.
  • Improved type safety and error handling across the system.

Breaking Changes

  • Updated method signatures for store and callback operations, now requiring orgId in many cases.
  • Changed resource conversion methods to return pointers and errors.
  • Modified callback function signatures to include organization context.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants