docs: document audit transaction fix and utc_now relocation (PR #5 follow-up)#6
Closed
cursor[bot] wants to merge 6 commits into
Closed
docs: document audit transaction fix and utc_now relocation (PR #5 follow-up)#6cursor[bot] wants to merge 6 commits into
cursor[bot] wants to merge 6 commits into
Conversation
Ship the local-first CLI, schemas, tests, and CI. Slim-repo docs link to canonical flightdeckdev/flightdeck main. OpenTelemetry is optional-only. Also: pytest basetemp under .tmp/pytest for Windows, Python 3.13–3.14 in CI, ruff 0.15.12 aligned with ruff-pre-commit, pre-commit-hooks v5, .gitattributes LF for golden bundle, CHANGELOG 1.0.1 section and empty Unreleased, RELEASE_NOTES v1.0.1 patch notes, README quickstart_smoke first. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
- CHANGELOG: add entries for insert_promotion_record BEGIN IMMEDIATE fix, utc_now move to flightdeck.models, and new write-lock test - RELEASE_NOTES: add 'Promotion audit write-lock guarantee' section explaining the BEGIN IMMEDIATE serialization contract, busy-timeout behaviour, and the new canonical location of utc_now() Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs added/updated
CHANGELOG.md— Unreleased sectionAdded three entries covering what landed in PR #5 ("Database audit sequence, utc_now"):
Storage.insert_promotion_recordnow usesBEGIN IMMEDIATE— explains the serialization fix: standalone promotion-record inserts now callself.transaction()(same ascommit_promotion) so theaudit_seqread-then-write is never racing with a concurrent writer.utc_nowmoved toflightdeck.models— documents the new canonical import location; callers importing fromflightdeck.storagemust update.test_insert_promotion_record_uses_immediate_transaction, which verifies the BEGIN IMMEDIATE guarantee by asserting a competing connection seesdatabase is locked.RELEASE_NOTES.md— new "Promotion audit write-lock guarantee" sectionAdded an operational runbook section under SQLite upgrades covering:
BEGIN IMMEDIATEand what that guarantees foraudit_seqcontiguity.sqlite3.OperationalError: database is locked) and the 5 s busy-timeout behaviour.utc_now()(flightdeck.models).Codepaths covered
src/flightdeck/storage.py—Storage.transaction(),Storage.insert_promotion_record(),Storage.commit_promotion(),Storage._next_audit_seq()src/flightdeck/models.py—utc_now()tests/test_doctor.py—test_insert_promotion_record_uses_immediate_transactionKey knowledge gaps addressed
BEGIN IMMEDIATEis required for promotion inserts (theaudit_seqgap-detection inflightdeck doctordepends on it).utc_nowwas a silent import-site change with no prior doc entry.