Web UI: sidebar Settings popover for Appearance (replace Settings page)#60
Closed
Gsbreddy wants to merge 8 commits into
Closed
Web UI: sidebar Settings popover for Appearance (replace Settings page)#60Gsbreddy wants to merge 8 commits into
Gsbreddy wants to merge 8 commits into
Conversation
Set per-route document titles, sync theme-color with light/dark, add Open Graph meta and clearer sidebar landmark text. Refine controls (touch-friendly buttons/inputs), layered card shadows, and striped data tables. Extend Playwright coverage for titles and theme-color. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Add Button (loading spinner, aria-busy) and StatusChip components; render API security as scannable Writes/Reads/UI token chips. Wire Diff, Runs, and Actions flows to Button; improve promote reason field validation UX, native-styled filters (fd-select), sticky overview tables, and fd-link on promoted release focus. Rebuild shipped static bundle; align smoke test with chip copy. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
cursor
Bot
changed the title
Include Playwright-generated MP4/WebM walkthrough and PNG stills under artifacts/flightdeck-demo-share for easy clone/download; document regeneration via web/scripts/capture-demo-artifacts.mjs. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
Actions: aria-busy tracks workspace load only; workspace error vs loading copy for token hint; field-level invalid flags for reason and confirm inputs; clear flags on API errors. Runs: mutual disable for load/export; invalid styling when release ID missing. SecurityStatusBar: data-testid, skip /health in read-only UI, unknown auth values with warn copy, chained detail messages; theme-color meta updates all tags. Button: preserve loading aria-busy over rest spread. useDocumentTitle: empty and suffix rules. Demo capture script aligns with e2e CLI resolution and closes browser in finally. Add security-strip e2e (bearer route mock); scope smoke assertion. Rebuild static bundle. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
Replace the dedicated Settings route with a portal dialog next to the footer control, keep theme persistence unchanged, redirect legacy #/settings to home, refresh e2e and demo capture docs, and rebuild the shipped static bundle. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
cursor
Bot
changed the title
Re-run capture-demo-artifacts against current serve UI; refresh README listing for all numbered PNGs plus WebM/MP4 outputs. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
Use sun/moon/monitor controls next to a Theme label, rename the dialog to Settings, tighten popover width, and refresh docs, e2e, demo captures, and the shipped static bundle. Co-authored-by: Gottam Sai Bharath <Gsbreddy@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#/settingsstill redirects home.flightdeck-themestorage). Screen readers still get Light / Dark / System via visually hidden labels.src/flightdeck/server/static/are updated.Test plan
cd web && npm run buildFLIGHTDECK_E2E_PYTHON="$(uv run python -c "import sys; print(sys.executable)")" npm run test:e2efromweb/uv run python -m ruff check src testsnode web/scripts/capture-demo-artifacts.mjs