Fix insert() and update() ignoring typed public properties#35
Merged
Merged
Conversation
Direct assignment to typed public properties bypasses __set(), so the internal $dirty array stays empty. This causes insert() to return early with nothing inserted, and update() to issue no UPDATE statement. Added syncDirtyFromProperties() which detects initialized declared properties and copies them into $dirty. For insert, all properties are synced. For update, only properties whose value differs from the last find() are synced. enlivenapp <mw@enlivenapp.com>
Contributor
|
Thanks for this! I just have used comment attributes in the past (when using Runway to generate a record for example), but this works too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a subclass with typed properties and attempted an insert:
I expected a new row to be inserted into the database.
Instead, nothing is inserted — the method returns early because
$dirtyis empty.The same issue affects
update()afterfind():I expected the name to be updated to
"Updated". Instead, no update is issued.Subclasses without typed properties are not affected.
Tests included. All existing tests continue to pass.