Unnecessary extra headers send

[joanhey]

Actually always add Cache-control and Expires headers.

If there is no Cache-Control header and no Expires header, and no Last-Modified header (which most web servers send by default for static assets) is never cached by the browser.

And Cache-Control (http 1.1) have preference over Expires (http 1.0)

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expires

Note: If there is a Cache-Control header with the max-age or s-maxage directive in the response, the Expires header is ignored.

Any app using an API with Flight, also don't need these headers.

[n0nag0n]

Are you talking about this section of code specifically?

https://github.com/flightphp/core/blob/master/flight/net/Response.php#L434-L438

I guess it'd be helpful to understand why those headers should just not be sent at all? I seem to recall needing to add them because otherwise API calls were mysteriously caching when they shouldn't have been even though different data sets were being sent.

[n0nag0n]

Also at this point you should just become an honorary member of flightphp with all the Issues and PR's you're helping with hahaha

[n0nag0n]

I found the original commit/PR, and yeah that's the reason why I had to add those.

#598

[joanhey]

Absolute none framework add that headers.

But remember no headers at all !!
Not Cache-control, Expires, Last-Modified and Pragma !!

Test it in local.

PD: if you add only 1 of these headers, then start the problem.

And please don't add the Content-Length, that's automatic in normal PHP.

[joanhey]

All that headers added to the response, are terrible for any benchmark !!
And for any app, the response only need to return the data and necessary headers.

[joanhey]

I can be an honorary member, but it's better if the people follow me, or help like sponsor.

[n0nag0n]

I did what you suggested and it looks like it's working as expected. My guess is that previously some header was added for caching elsewhere and it's since been fixed. I'll take the performance win! Thanks!

#630