Skip to content

Allow Symfony 4 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ciaranmcnulty wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow Symfony 4 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7835588
Enable Symfony 4
ciaranmcnulty Apr 7, 2018
524a800
Specify compatible local PHPUnit versions
ciaranmcnulty Apr 7, 2018
7a2076a
Handle different exception for missing files in Symfony 3.1
ciaranmcnulty Apr 7, 2018
3c67815
Simplify inotify installation and tet with fewer PHP versions
ciaranmcnulty Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ language: php

sudo: false


cache:
directories:
- $HOME/.composer/cache/files
Expand All @@ -12,18 +11,18 @@ php:
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm

matrix:
include:
- php: 5.4
env: INOTIFY_EXTENSION=1
- php: 5.5
env: INOTIFY_EXTENSION=1
- php: 5.6
env: INOTIFY_EXTENSION=1

before_script:
- "if [ \"$INOTIFY_EXTENSION\" = \"1\" ]; then pyrus install pecl/inotify && pyrus build pecl/inotify; fi"
- "if [ \"$INOTIFY_EXTENSION\" = \"1\" ]; then echo \"extension=inotify.so\" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini; fi"
- "if [ \"$INOTIFY_EXTENSION\" = \"1\" ]; then pecl install inotify-0.1.6; fi"
- "composer install --no-progress"

script:
- "vendor/bin/phpunit"
7 changes: 5 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

"require" : {
"php" : ">=5.3.3",
"symfony/config" : "^2.2|^3.0",
"symfony/event-dispatcher" : "^2.2|^3.0"
"symfony/config" : "^2.2 || ^3.0 || ^4.0",
"symfony/event-dispatcher" : "^2.2 || ^3.0 || ^4.0"
},

"autoload" : {
Expand All @@ -38,5 +38,8 @@
"branch-alias" : {
"dev-master" : "1.0.x-dev"
}
},
"require-dev": {
"phpunit/phpunit": "^4.0 || ^5.0"
}
}
7 changes: 3 additions & 4 deletions tests/Lurker/Tests/Tracker/TrackerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,16 @@ public function tearDown()
}

/**
* @expectedException Lurker\Exception\InvalidArgumentException
* @expectedException \InvalidArgumentException
*/
public function testDoesNotTrackMissingFiles()
{
$tracker = $this->getTracker();

$tracker->track(new TrackedResource('missing', new FileResource(__DIR__.'/missingfile')));
$tracker->track(new TrackedResource('missing', new FileResource(__DIR__ . '/missingfile')));
}

/**
* @expectedException Lurker\Exception\InvalidArgumentException
* @expectedException \InvalidArgumentException
*/
public function testDoesNotTrackMissingDirectories()
{
Expand Down