Speed up nmod_addmul and fullword _nmod_vec_scalar_mul_nmod, _nmod_vec_scalar_addmul_nmod#2529
Merged
fredrik-johansson merged 1 commit intoflintlib:mainfrom Dec 17, 2025
Merged
Conversation
…c_scalar_addmul_nmod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nmod_addmulis replaced with simpler and faster code which simplifies and speeds up the generic fallback in_nmod_vec_scalar_addmul_nmod. The old code for 64-bit moduli in_nmod_vec_scalar_addmul_nmodwas particularly bad; the new code is more than 3x faster.Also,
nmod_redc_mulis used to speed up the 64-bit case in_nmod_vec_scalar_mul_nmodwhere Shoup can't be used. Asymptotically this is about 20% faster than the old code, with the only restriction is thatnneeds to be odd to benefit.Timings on Zen 3: