Fix fprint functions writing to stdout instead of the given stream#2587
Merged
albinahlback merged 1 commit intoflintlib:mainfrom Mar 2, 2026
Merged
Conversation
nmod_mat_fprint_pretty and _nmod_vec_fprint_pretty used flint_printf (which writes to stdout) instead of flint_fprintf(file, ...) for the matrix/vector body, so only the header went to the correct stream. Fixes flintlib#2585
Collaborator
|
Great Edgar! |
Member
Author
|
I was just trying to prove that I am not dead :) |
Member
Author
|
Oh, I also didn't see your PR. sorry |
Collaborator
haha, don't worry, I didn't catch the nmod_vec stuff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2585