Karp-Markstein radix division#2588
Merged
fredrik-johansson merged 1 commit intoflintlib:mainfrom Mar 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Newton division for
radixto use the Karp-Markstein trick (fusing the multiplication by the numerator with the last Newton iteration, allowing it to be performed with half precision). Typical speedups are 10-20% for division with remainder and 20-30% for division (with maximal speedups of 40% and 90% respectively):Profile outputs:
This is now getting substantially faster than the
mpn/fmpzdivision code for many sizes; quite likely thempn/fmpzcode can be made 20-30% faster than its current speed by using all the currentradixtricks.