Merged
Conversation
Collaborator
|
Thanks @tthsqe12 it is indeed a huge PR. I hope that I can review it quickly! |
Contributor
Author
|
The messes that remain are quite embarrassing. I have a hodgepodge of bivariate arithmetic without a home, and I have to see what part of the official fq embedding interface is salvageable for my needs. It all works now (hopefully). I still need to add newton methods and more code comments, and update the algorithms documentation, and from now on will hopefully be able to accomplish this with small commits. |
Contributor
Author
|
@wbhart I am satisfied with this pr. There is one more major thing that I have to do, which I will save for a later PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my long-awaited complete rewrite of fq_nmod_mpoly. Some of the factoring code is cleaner now, but I still would like to check one thing before it can be merged.