-
Notifications
You must be signed in to change notification settings - Fork 34
Fix arb.neg() #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arb.neg() #336
Conversation
|
It looks like you have run a formatter such as black or ruff on the test code. Those formatting changes should be reverted and if we do want to use a formatter then that should be done in a separate PR. |
c41d1d0 to
997ecfd
Compare
|
Oops, sorry about that, I have black and isort set to run automatically on save in my editor. Fixed. |
|
Looks good. Thanks. Can you add a release note with your name here in the README: Lines 162 to 175 in e8e716b
|
Done! |
|
Looks good. Thanks! |
|
It would be good to have some more testing for arb so any contribution is welcome. Mostly it is only covered by doctests and those are also quite flakey for arb given that in different FLINT versions the exact ball boundaries are not stable. |
|
For testing purposes now that this PR is merged you can install the nightly wheel with these changes from here: If you want to add something in CI to test with these then that is a good option. |
Fixes #335, and adds tests for
arb.neg()