Skip to content

Fix mesh picking and rotation gizmo configuration #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tracygardner wants to merge 1 commit into from
+2 −1
Closed

Fix mesh picking and rotation gizmo configuration #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/gizmos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,7 @@
activePick = { pointerObservable, pointerObserver };

setTimeout(() => {
if (hasPicked) return;
startCanvasKeyboardMode(
(x, y) => {
const pick = flock.scene.pick(x, y);
Expand Down Expand Up @@ -1379,7 +1380,7 @@

// Rotation: Allow the user to rotate the mesh by dragging it
function handleRotationGizmo() {
configureRotationGizmo(gizmoManager, { updateToMatchAttachedMesh: true });
configureRotationGizmo(gizmoManager);

// Show that rotation is active
const rotationButton = document.getElementById("rotationButton");
Expand Down Expand Up @@ -1573,7 +1574,7 @@

// Bounds: Allow the user to move the mesh
// Legacy?
function handleBoundsGizmo() {

Check failure on line 1577 in ui/gizmos.js

View workflow job for this annotation

GitHub Actions / eslint 

'handleBoundsGizmo' is defined but never used. Allowed unused vars must match /^_/u
gizmoManager.boundingBoxGizmoEnabled = true;
gizmoManager.boundingBoxDragBehavior.onDragStartObservable.add(function () {
const mesh = gizmoManager.attachedMesh;
Expand Down
Loading