Conversation
Reorders gate evaluation so percentage-of-time is checked before group, aligning with Ruby Flipper's precedence. Adds regression test asserting the winning gate via instrumentation.
Delete GATE_PRECEDENCE_PARITY_PLAN.md which detailed the plan for aligning gate precedence and semantics between the Ruby and TypeScript implementations. This file is no longer needed as all listed parity gaps have been completed. Reduces clutter and clarifies the project's current documentation needs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Flipper typescript gate evaluation previously did not match Flipper Ruby's precedence order, causing discrepancies in which gates took priority for feature toggling. Percentage-of-actors bucketing differed from Ruby, expression gates didn't evaluate against actor properties, numeric gates and expressions did not disable other gates correctly, and actors with missing IDs weren't closed consistently. This led to nondeterministic toggling, inconsistent feature state, and difficulty asserting correct behavior across platforms.
How?