Skip to content

[FL-3965] Separate cli_shell into toolbox #4147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
portasynthinca3 wants to merge 112 commits into from
Closed

[FL-3965] Separate cli_shell into toolbox #4147

portasynthinca3 wants to merge 112 commits into from

Conversation

@portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Mar 12, 2025 •
edited
Loading

What's new

  • cli_shell and friends have been made more generic and extracted into toolbox, allowing commands to define their own shells
  • Command to test subshells subshell_demo

Verification

  • Run unit tests
  • Verify that the shell still functions as intended (incl. with companion apps)
  • Run subshell_demo, verify that it works as intended

Remarks

This PR depends on #4116 and #4115. Please review and merge them and their dependent PRs first.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3
feat: FuriThread stdin
bf7fefc
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
a9d3264
@portasynthinca3
ci: fix f18
4c59243
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
9f2e934
@portasynthinca3
feat: stdio callback context
f1eb60b
@portasynthinca3
Merge branch 'dev' into portasynthinca3/3927-thread-stdin
da187fe
@portasynthinca3
feat: FuriPipe
a4a7a41
@portasynthinca3
POTENTIALLY EXPLOSIVE pipe welding
004e3a6
@portasynthinca3
fix: non-explosive welding
920a3e9
@portasynthinca3
Revert welding
f792fde
@portasynthinca3
docs: furi_pipe
1c9dbb3
@portasynthinca3
feat: pipe event loop integration
bd28387
@portasynthinca3
update f18 sdk
acf307d
@portasynthinca3
f18
2bcc3c4
@portasynthinca3
docs: make doxygen happy
af7ff81
@portasynthinca3
fix: event loop not triggering when pipe attached to stdio
857ad33
@portasynthinca3
fix: partial stdout in pipe
bc9223a
@portasynthinca3
allow simultaneous in and out subscription in event loop
dac9c00
@portasynthinca3
feat: vcp i/o
8837c8b
@portasynthinca3
feat: cli ansi stuffs and history
20ce18f
@portasynthinca3
feat: more line editing
1b31e70
@portasynthinca3
working but slow cli rewrite
82169a7
@portasynthinca3
restore previous speed after 4 days of debugging 🥲
fa1919c
@portasynthinca3
fix: cli_app_should_stop
bd82671
@portasynthinca3
fix: cli and event_loop memory leaks
34c6566
@portasynthinca3
style: remove commented out code
a346d8c
@portasynthinca3
ci: fix pvs warnings
c3f7825
@portasynthinca3
fix: unit tests, event_loop crash
b0b73c0
@portasynthinca3
ci: fix build
8e05df6
@portasynthinca3
ci: silence pvs warning
789e337
@github-actions
Copy link

github-actions bot commented Mar 12, 2025 •
edited
Loading

PVS-Studio report for commit 33fe8f33:

@github-actions
Copy link

github-actions bot commented Mar 12, 2025 •
edited
Loading

Compiled f7 firmware for commit cb9db315:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review March 12, 2025 21:59
@RebornedBrain RebornedBrain mentioned this pull request Mar 26, 2025
Merged
6 tasks
@hedger hedger added Core+Services HAL, furi & core system services App Loader FAP loader + API-related labels Apr 3, 2025
@portasynthinca3 portasynthinca3 marked this pull request as draft April 3, 2025 18:08
@portasynthinca3 portasynthinca3 force-pushed the portasynthinca3/3965-cli_shell-toolbox branch from 33fe8f3 to cb9db31 Compare April 3, 2025 18:14
@portasynthinca3 portasynthinca3 deleted the portasynthinca3/3965-cli_shell-toolbox branch April 3, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

Assignees

No one assigned

Labels

App Loader FAP loader + API-related Core+Services HAL, furi & core system services

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@portasynthinca3 @hedger @gsurkov @skotopes