test: smoke-test the PR review agent#2
Closed
markphelps wants to merge 2 commits into
Closed
Conversation
Contributor
markphelps
commented
May 27, 2026
markphelps
commented
A throwaway file with a few intentional issues (loop bound, empty-input division, missing input validation) so the review workflow has something to find. Not imported anywhere; delete after verifying. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: request changes
This PR introduces a smoke-test fixture with intentional issues for the review agent. The file contains several correctness problems that must be fixed before merging. See below for details on ranking and problems found.
examples/_smoke-test/sample.ts
- critical (L8): The loop in
averageScoreshould iterate up toi < scores.length, noti <= scores.length, to avoid accessing out-of-bounds array elements and including undefined in the sum. - major (L9): The addition
total += scores[i];may sum an undefined value due to the loop bounds. Bounds logic should be corrected. - major (L11): If the input array is empty,
scores.lengthis zero, resulting in a division by zero. Handle empty arrays gracefully (e.g. return 0 or throw).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.