fix: post reviews deterministically from the workflow (not the model)#5
Conversation
markphelps
commented
May 27, 2026
markphelps
commented
gpt-4.1 would return verdict/findings and claim `posted: true` without ever running `gh pr review` — so reviews silently weren't posted on flipt. Move posting out of the model's control: the skill now only returns verdict/summary/findings, and the workflow renders the markdown and posts it via `gh pr review --comment` (falling back to `gh pr comment`), setting `posted` from the actual exit status. Adds @types/node for node:child_process; drops the process shim from flue-env.d.ts. Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: approve
This PR updates structured review posting and ensures all PR review logic is posted deterministically by the workflow, not the model. All changes are sound, align with standing correctness and clarity rules, and improve maintainability. No correctness, security, or major maintainability issues found. Only minor optional nits noted above.
skills/code-review/SKILL.md
- nit (L15): Line could be clarified: 'the workflow posts your returned result to the PR.' might be improved for readability to 'your returned result is posted to the PR by the workflow.' However, this is minor and does not affect functionality.
package.json
- nit (L8): Minor style: List script entries in consistent order ('review' before 'dev'). Not a blocker.
🤖 Automated review by the Flue PR review agent.
… permissions, action visibility) Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
There was a problem hiding this comment.
Verdict: comment
This PR modernizes review posting, making it deterministic and handled by the workflow, not the model. Minor suggestions relate to documentation clarity, a possible obsolete comment in typings, and devDependency formatting. No issues that block merging.
README.md
- minor (L7): Update the description on line 7 to clarify that the workflow posts the review rather than the model, ensuring users don't expect the model to handle posting.
flue-env.d.ts
- nit (L3): Remove commented-out block about process.env at the end if it is obsolete per recent changes.
package.json
- minor (L21): Keep devDependencies properly sorted and remove trailing commas after the last item in the list for consistency.
🤖 Automated review by the Flue PR review agent.
…nstead of node child_process Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
There was a problem hiding this comment.
Verdict: approve
Looks good — no changes requested. The PR updates documentation to clarify model handling and posting strategy, refines type-checking and review schema, and improves deterministic review posting. All changes are clear, correct, and follow project conventions. No issues found worth blocking or commenting on.
🤖 Automated review by the Flue PR review agent.
1 participant
