Skip to content

fix(authn): use UserInfo claims as fallback for missing OIDC fields#5692

Merged
kodiakhq[bot] merged 1 commit intov2from
rd/v2/oidc-extra-attrs
Apr 7, 2026
Merged

fix(authn): use UserInfo claims as fallback for missing OIDC fields#5692
kodiakhq[bot] merged 1 commit intov2from
rd/v2/oidc-extra-attrs

Conversation

@erka
Copy link
Copy Markdown
Contributor

@erka erka commented Apr 7, 2026

When FetchExtraUserInfo is enabled, the UserInfo endpoint may provide additional
claims (name, email, picture). Previously these were extracted by not
used for metadata attributes as the result UI doesn't show user's name and
picture. Now the ID token claims take priority, and UserInfo claims fill in only the
fields that are nil or empty.

related #5364

@erka erka requested a review from a team as a code owner April 7, 2026 14:02
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 7, 2026
@erka erka added the v2 Flipt v2 label Apr 7, 2026
@erka erka added the automerge Used by Kodiak bot to automerge PRs label Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.17%. Comparing base (383277e) to head (08df08b).
⚠️ Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #5692      +/-   ##
==========================================
+ Coverage   61.12%   61.17%   +0.04%     
==========================================
  Files         141      141              
  Lines       14170    14185      +15     
==========================================
+ Hits         8662     8677      +15     
  Misses       4777     4777              
  Partials      731      731              
Flag Coverage Δ
integrationtests 34.49% <12.50%> (-0.04%) ⬇️
unittests 52.06% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

When FetchExtraUserInfo is enabled, the UserInfo endpoint may provide additional
claims (name, email, picture). Previously these were extracted by not
used for metadata attributes as the result UI doesn't show user's name and
picture. Now the ID token claims take priority, and UserInfo claims fill in only the
fields that are nil or empty.

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka force-pushed the rd/v2/oidc-extra-attrs branch from b2889e9 to 08df08b Compare April 7, 2026 17:21
@kodiakhq kodiakhq Bot merged commit 5f76d22 into v2 Apr 7, 2026
32 checks passed
@kodiakhq kodiakhq Bot deleted the rd/v2/oidc-extra-attrs branch April 7, 2026 18:51
@github-project-automation github-project-automation Bot moved this to Done in Flipt V2 Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:M This PR changes 30-99 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants