This repository was archived by the owner on Jun 24, 2025. It is now read-only.
[Work In Progress]: Update to 3.0.2 MongoDB Driver#13
Closed
Lily418 wants to merge 3 commits intofloatdrop:masterfrom
Closed
[Work In Progress]: Update to 3.0.2 MongoDB Driver#13Lily418 wants to merge 3 commits intofloatdrop:masterfrom
Lily418 wants to merge 3 commits intofloatdrop:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
There was a breaking change in MongoDB 3.0.0
What this PR Does
This PR adds database name as an additional parameter and adds this database to the req object.
Performance
I believe that using the db method this way is not a performace issue because these instances will be cached.
Alternatives
It would be possible to rewrite this to make database name optional and return either a client object or a database object depending on if database name is provided. Not sure how common users will want to connect to multiple databases so for now avoided the extra code complexity.
Issues
I've encountered an issue with updating the tests, they timeout and I'm not sure what is still running that's stopping the process from ending.
I'm not familiar with tap so not sure how to proceed with with.