Skip to content

BUG: File write errors ignored in debug logger #751

@andrinoff

Description

@andrinoff

Describe the bug
Debug logger at view/html.go:256-261 ignores file write and close errors. Uses pattern _, _ = f.WriteString(msg) and _ = f.Close() which silently fails.

To reproduce

  1. Set DEBUG_IMAGE_PROTOCOL_LOG env var
  2. Fill disk or remove write permissions
  3. Debug output silently lost

Expected behavior
Log errors or use defer with error check

Matcha version
master

OS
All

Additional context
File: view/html.go lines 256-261

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomersneeds-responseWaiting on issue author replystaleNo activity for extended period

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    In review

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions