-
-
Notifications
You must be signed in to change notification settings - Fork 72
BUG: File write errors ignored in debug logger #751
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersneeds-responseWaiting on issue author replyWaiting on issue author replystaleNo activity for extended periodNo activity for extended period
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersneeds-responseWaiting on issue author replyWaiting on issue author replystaleNo activity for extended periodNo activity for extended period
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
In review
Describe the bug
Debug logger at view/html.go:256-261 ignores file write and close errors. Uses pattern _, _ = f.WriteString(msg) and _ = f.Close() which silently fails.
To reproduce
Expected behavior
Log errors or use defer with error check
Matcha version
master
OS
All
Additional context
File: view/html.go lines 256-261