Skip to content

BUG: Missing nil checks on file operations in fetcher #758

@andrinoff

Description

@andrinoff

Describe the bug
File operations at fetcher/fetcher.go:1029,1035 open files without defer close. If error occurs after open, file descriptor leaks.

To reproduce

  1. Open file for attachment processing
  2. Error occurs in processing
  3. File never closed, descriptor leaked

Expected behavior
Use defer file.Close() immediately after successful open

Matcha version
master

OS
All

Additional context
Files: fetcher/fetcher.go lines 1029, 1035
Missing defer on file.Close()

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions