fix: pass through in search#1203
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 30, 2026
Merged
Conversation
Closes floatpane#1199 When the inbox search overlay was open (after pressing /), folder-level keybindings such as 'm' (move) were intercepted by FolderInbox.Update before the inner inbox could route the keystroke to the search input. This caused the user to start a move-to-folder flow instead of typing the letter into the search field. Skip the FolderInbox keypress switch while m.inbox.searchOverlay != nil so the message falls through to m.inbox.Update, which already routes overlay keys to SearchOverlay.Update for text input.
floatpanebot
previously requested changes
Apr 30, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @mvanhorn! Please fix the following issues with your PR:
- Title: Is too long (52 characters). The PR title must be strictly under 40 characters.
Member
|
/build |
Member
Build complete (
|
| OS | Arch | Download |
|---|---|---|
| Linux | amd64 | matcha_preview_linux_amd64.tar.gz |
| Linux | arm64 | matcha_preview_linux_arm64.tar.gz |
| macOS | amd64 | matcha_preview_darwin_amd64.tar.gz |
| macOS | arm64 | matcha_preview_darwin_arm64.tar.gz |
| Windows | amd64 | matcha_preview_windows_amd64.zip |
| Windows | arm64 | matcha_preview_windows_arm64.zip |
andrinoff
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Member
|
/approve |
floatpanebot
approved these changes
Apr 30, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In
tui/folder_inbox.go, skip theFolderInbox.Updatekeypress switch whilem.inbox.searchOverlay != nilso the message falls through tom.inbox.Update, which already routes overlay keys toSearchOverlay.Updatefor text input.Adds
TestSearchOverlayKeysNotInterceptedintui/folder_inbox_test.goto lock in the behavior. The test fails onmasterand passes after the fix.Why?
Closes #1199.
FolderInbox.Updateruns before the innerInbox.Update. When the search overlay was open (after pressing/), folder-level keybindings such askb.Folder.Move(defaultm) matched onmsg.String()and started the move-to-folder flow instead of letting the keystroke reach the search input. Reproducer from the issue: enter inbox ->/-> pressmand the "Move to folder:" popup appears.Other
kb.Folder.*bindings (tab,shift+tab,],[) had the same problem in principle. Routing all keys through to the inner inbox while the overlay is open fixes them in one place. The overlay's ownEschandler inInbox.Update(line 647-650) still works because the inbox's keypress branch checksm.searchOverlay != nilfirst.