fix: split pane html conv and table fix#1246
Merged
andrinoff merged 1 commit intofloatpane:masterfrom May 7, 2026
Merged
Conversation
Signed-off-by: drew <me@andrinoff.com>
Member
Author
|
/build |
floatpanebot
previously requested changes
May 7, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @andrinoff! Please fix the following issues with your PR:
- Title: Is too long (40 characters). The PR title must be strictly under 40 characters.
andrinoff
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Member
Build complete (
|
| OS | Arch | Download |
|---|---|---|
| Linux | amd64 | matcha_preview_linux_amd64.tar.gz |
| Linux | arm64 | matcha_preview_linux_arm64.tar.gz |
| macOS | amd64 | matcha_preview_darwin_amd64.tar.gz |
| macOS | arm64 | matcha_preview_darwin_arm64.tar.gz |
| Windows | amd64 | matcha_preview_windows_amd64.zip |
| Windows | arm64 | matcha_preview_windows_arm64.zip |
Member
Author
|
/approve |
floatpanebot
approved these changes
May 7, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes split pane HTML conversion, according to #1213
Also changes in
view/html.go:renderHTMLToTexthelper.processBodynow: ifmimeType == text/htmland direct render is whitespace-only, retry throughmarkdownToHTMLpre-passWhy?
Certain emails are not displayed correctly, as pointed by @EmilyxFox. Also, split pane was displaying emails incorrectly not as per #1213 fix.