feat: plugin settings SDK#1266
Merged
Merged
Conversation
Co-authored-by: Lea <lea@floatpane.com> Co-authored-by: Steve Evans <steve@floatpane.com> Signed-off-by: drew <me@andrinoff.com>
floatpanebot
added
area/tui
FromSi
reviewed
May 9, 2026
FromSi
reviewed
May 9, 2026
Signed-off-by: drew <me@andrinoff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds user-configurable plugin settings. Plugins declare typed options via a new
matcha.settings(spec)Lua API supportingboolean,number, andstringtypes with defaults, labels, and descriptions. The call returns a read-only proxy table whose fields reflect live values, so hook callbacks read current settings through closure capture. A second helpermatcha.get_setting(key [, plugin])provides explicit lookup. The plugin Manager tracks the loading plugin so schemas attribute correctly, and gains methods for reading, writing, loading, and exporting setting values with type coercion. Values persist inconfig.jsonunder a newplugin_settingsfield (both regular and secure-mode disk formats).Why?
Plugins shipped hardcoded constants (keyword lists, thresholds, toggles). Users had to edit Lua source to tweak them — fragile and lost on plugin reinstall. Plugins now declare schemas; users edit values in TUI; values persist across upgrades. Bool toggle avoids parser errors from typing
true/false/1/0inconsistently.