fix(composer): validate recipients#1310
Conversation
|
@andriy-chernov need help with i18n |
| } | ||
| fromOverride := "" | ||
| if m.isCatchAllAccount() { | ||
| fromOverride = m.fromInput.Value() |
There was a problem hiding this comment.
@andrinoff Please double-check this FromOverride path for catch-all accounts. This value may not always be in the format expected by SMTP and could cause a syntax error like: 501 5.5.2 Syntax error, expected: MAIL FROM:<reverse-path> [parameters]. Thanks!
There was a problem hiding this comment.
SMTP expects Name <email@something.com>.
for catch-all accounts, you can make a mistake there, yes.
You can add the check for it too, if you want. Just make sure to include that for accounts that do not have a name just@email.com is needed.
|
ill check everything out tomorrow, @mavonx, you too. crisis IRL |
f9d23a9 to
11ceed9
Compare
11ceed9 to
2292865
Compare
2292865 to
ddd0095
Compare
|
done, @andrinoff move the commit, please |
Hope everything gets better soon. |
|
@andriy-chernov Sorry, I just noticed that the |
Signed-off-by: drew <me@andrinoff.com>
What?
Added recipient validation in the composer for
To,Cc, andBccfields.mail.ParseAddress()when leaving a recipient field.Why?
This prevents confusing SMTP failures caused by invalid recipient input and gives users immediate feedback inside the composer.
Closes #648
Closes #734
Testing
Added composer tests for: