fix: keep empty part path#1321
Merged
Merged
Conversation
floatpanebot
previously requested changes
May 21, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @resolvicomai! Please fix the following issues with your PR:
- Body: Missing the
## What?or## Why?headings required by the PR template.
resolvicomai
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
andrinoff
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #1113.
formatPartPathnow returns an empty string for nil/empty paths instead of silently formatting them as part1. A regression test covers both nil and empty slices.Why?
parsePartIDalready treats an empty string as the nil-path convention, while1is a real MIME part. Returning1for an empty walk path can mask caller bugs and fetch the wrong part.Validation:
go test ./fetcher -run TestFormatPartPathEmptyPath -count=1go test ./fetcher -count=1go test ./...make lintgit diff --check