fix: lint issues

backend/jmap/jmap.go

@@ -23,6 +23,8 @@ import (
 	"github.com/floatpane/matcha/config"
 )
 
+const jmapMailboxIds = "mailboxIds"
+
 func init() {
 	backend.RegisterBackend("jmap", func(account *config.Account) (backend.Provider, error) {
 		return New(account)
@@ -167,7 +169,7 @@ func (p *Provider) FetchEmails(_ context.Context, folder string, limit, offset u
 		},
 		Properties: []string{
 			"id", "subject", "from", "to", "replyTo", "receivedAt",
-			"preview", "keywords", "mailboxIds", "hasAttachment",
+			"preview", "keywords", jmapMailboxIds, "hasAttachment",
 			"messageId", "inReplyTo", "references",
 		},
 	})
@@ -220,7 +222,7 @@ func (p *Provider) Search(_ context.Context, folder string, query backend.Search
 		},
 		Properties: []string{
 			"id", "subject", "from", "to", "replyTo", "receivedAt",
-			"preview", "keywords", "mailboxIds", "hasAttachment",
+			"preview", "keywords", jmapMailboxIds, "hasAttachment",
 			"messageId",
 		},
 	})
@@ -356,7 +358,7 @@ func (p *Provider) FetchAttachment(_ context.Context, _ string, _ uint32, partID
 	if err != nil {
 		return nil, fmt.Errorf("jmap download: %w", err)
 	}
-	defer reader.Close()
+	defer reader.Close() //nolint:errcheck
 	return io.ReadAll(reader)
 }
 
@@ -419,7 +421,7 @@ func (p *Provider) DeleteEmail(_ context.Context, _ string, uid uint32) error {
 	req.Invoke(&email.Set{
 		Account: p.accountID,
 		Update: map[jmapclient.ID]jmapclient.Patch{
-			jmapID: {"mailboxIds": map[jmapclient.ID]bool{trashID: true}},
+			jmapID: {jmapMailboxIds: map[jmapclient.ID]bool{trashID: true}},
 		},
 	})
 	_, err = p.client.Do(req)
@@ -441,7 +443,7 @@ func (p *Provider) ArchiveEmail(_ context.Context, _ string, uid uint32) error {
 	req.Invoke(&email.Set{
 		Account: p.accountID,
 		Update: map[jmapclient.ID]jmapclient.Patch{
-			jmapID: {"mailboxIds": map[jmapclient.ID]bool{archiveID: true}},
+			jmapID: {jmapMailboxIds: map[jmapclient.ID]bool{archiveID: true}},
 		},
 	})
 	_, err = p.client.Do(req)
@@ -463,7 +465,7 @@ func (p *Provider) MoveEmail(_ context.Context, uid uint32, _, dstFolder string)
 	req.Invoke(&email.Set{
 		Account: p.accountID,
 		Update: map[jmapclient.ID]jmapclient.Patch{
-			jmapID: {"mailboxIds": map[jmapclient.ID]bool{dstID: true}},
+			jmapID: {jmapMailboxIds: map[jmapclient.ID]bool{dstID: true}},
 		},
 	})
 	_, err = p.client.Do(req)
@@ -596,7 +598,7 @@ func (p *Provider) SendEmail(_ context.Context, msg *backend.OutgoingEmail) erro
 	if sentID != "" {
 		subReq.OnSuccessUpdateEmail = map[jmapclient.ID]jmapclient.Patch{
 			"#sub": {
-				"mailboxIds":      map[jmapclient.ID]bool{sentID: true},
+				jmapMailboxIds:    map[jmapclient.ID]bool{sentID: true},
 				"keywords/$draft": nil,
 			},
 		}
@@ -690,7 +692,7 @@ func (p *Provider) lookupJMAPID(uid uint32) (jmapclient.ID, error) {
 // jmapIDToUID converts a JMAP string ID to a uint32 hash for use as a UID.
 func jmapIDToUID(id jmapclient.ID) uint32 {
 	h := fnv.New32a()
-	h.Write([]byte(id))
+	h.Write([]byte(id)) //nolint:gosec
 	v := h.Sum32()
 	if v == 0 {
 		v = 1

backend/maildir/maildir.go

@@ -10,6 +10,7 @@ package maildir
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"mime"
@@ -165,7 +166,7 @@ func (p *Provider) readHeader(msg *emaildir.Message) (backend.Email, error) {
 	if err != nil {
 		return backend.Email{}, err
 	}
-	defer rc.Close()
+	defer rc.Close() //nolint:errcheck
 
 	entity, err := message.Read(rc)
 	if err != nil && entity == nil {
@@ -194,7 +195,7 @@ func (p *Provider) FetchEmailBody(_ context.Context, folder string, uid uint32)
 	if err != nil {
 		return "", "", nil, fmt.Errorf("maildir open: %w", err)
 	}
-	defer rc.Close()
+	defer rc.Close() //nolint:errcheck
 
 	return parseMessageBody(rc)
 }
@@ -209,7 +210,7 @@ func (p *Provider) FetchAttachment(_ context.Context, folder string, uid uint32,
 	if err != nil {
 		return nil, fmt.Errorf("maildir open: %w", err)
 	}
-	defer rc.Close()
+	defer rc.Close() //nolint:errcheck
 
 	return findAttachmentData(rc, partID)
 }
@@ -348,7 +349,7 @@ func (p *Provider) matchOpen(msg *emaildir.Message) (backend.Email, string, erro
 	if err != nil {
 		return backend.Email{}, "", err
 	}
-	defer rc.Close()
+	defer rc.Close() //nolint:errcheck
 
 	entity, err := message.Read(rc)
 	if err != nil && entity == nil {
@@ -552,7 +553,7 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 
 	for {
 		part, err := mr.NextPart()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		if err != nil {
@@ -568,7 +569,8 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 			continue
 		}
 
-		if disposition == "attachment" || (disposition == "inline" && !strings.HasPrefix(contentType, "text/")) {
+		switch {
+		case disposition == "attachment" || (disposition == "inline" && !strings.HasPrefix(contentType, "text/")):
 			filename := dParams["filename"]
 			if filename == "" {
 				_, cp, _ := mime.ParseMediaType(part.Header.Get("Content-Type"))
@@ -585,9 +587,9 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 				att.ContentID = strings.Trim(cid, "<>")
 			}
 			attachments = append(attachments, att)
-		} else if contentType == "text/html" {
+		case contentType == "text/html":
 			htmlBody = string(data)
-		} else if contentType == "text/plain" && bodyText == "" {
+		case contentType == "text/plain" && bodyText == "":
 			bodyText = string(data)
 		}
 	}
@@ -608,7 +610,7 @@ func findAttachmentData(r io.Reader, targetPartID string) ([]byte, error) {
 	partIdx := 0
 	for {
 		part, err := mr.NextPart()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		if err != nil {

backend/maildir/maildir_test.go

@@ -2,6 +2,7 @@ package maildir
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -238,15 +239,15 @@ func TestArchiveEmailRequiresArchiveFolder(t *testing.T) {
 	p := newProvider(t, root)
 	emails, _ := p.FetchEmails(context.Background(), "INBOX", 10, 0)
 	err := p.ArchiveEmail(context.Background(), "INBOX", emails[0].UID)
-	if err != backend.ErrNotSupported {
+	if !errors.Is(err, backend.ErrNotSupported) {
 		t.Errorf("want ErrNotSupported, got %v", err)
 	}
 }
 
 func TestSendEmailNotSupported(t *testing.T) {
 	root := makeMaildir(t)
 	p := newProvider(t, root)
-	if err := p.SendEmail(context.Background(), &backend.OutgoingEmail{}); err != backend.ErrNotSupported {
+	if err := p.SendEmail(context.Background(), &backend.OutgoingEmail{}); !errors.Is(err, backend.ErrNotSupported) {
 		t.Errorf("want ErrNotSupported, got %v", err)
 	}
 }

backend/pop3/pop3.go

@@ -11,6 +11,7 @@ package pop3
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 	"mime"
@@ -78,7 +79,7 @@ func (p *Provider) connect() (*pop3client.Conn, error) {
 	}
 
 	if err := conn.Auth(p.account.Email, p.account.Password); err != nil {
-		conn.Quit()
+		_ = conn.Quit()
 		return nil, fmt.Errorf("pop3 auth: %w", err)
 	}
 
@@ -90,7 +91,7 @@ func (p *Provider) FetchEmails(_ context.Context, _ string, limit, offset uint32
 	if err != nil {
 		return nil, err
 	}
-	defer conn.Quit()
+	defer conn.Quit() //nolint:errcheck
 
 	// Get message list with UIDs
 	msgs, err := conn.Uidl(0)
@@ -139,7 +140,7 @@ func (p *Provider) FetchEmailBody(_ context.Context, _ string, uid uint32) (stri
 	if err != nil {
 		return "", "", nil, err
 	}
-	defer conn.Quit()
+	defer conn.Quit() //nolint:errcheck
 
 	msgID, err := p.findMessageByUID(conn, uid)
 	if err != nil {
@@ -159,7 +160,7 @@ func (p *Provider) FetchAttachment(_ context.Context, _ string, uid uint32, part
 	if err != nil {
 		return nil, err
 	}
-	defer conn.Quit()
+	defer conn.Quit() //nolint:errcheck
 
 	msgID, err := p.findMessageByUID(conn, uid)
 	if err != nil {
@@ -212,7 +213,7 @@ func (p *Provider) DeleteEmails(_ context.Context, _ string, uids []uint32) erro
 
 	messageIDsByUID, err := p.buildMessageIDsByUID(conn)
 	if err != nil {
-		conn.Quit()
+		_ = conn.Quit()
 		return err
 	}
 
@@ -415,7 +416,7 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 
 	for {
 		part, err := mr.NextPart()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		if err != nil {
@@ -431,7 +432,8 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 			continue
 		}
 
-		if disposition == "attachment" || (disposition == "inline" && !strings.HasPrefix(contentType, "text/")) {
+		switch {
+		case disposition == "attachment" || (disposition == "inline" && !strings.HasPrefix(contentType, "text/")):
 			filename := dParams["filename"]
 			if filename == "" {
 				_, cp, _ := mime.ParseMediaType(part.Header.Get("Content-Type"))
@@ -448,9 +450,9 @@ func parseMessageBody(r io.Reader) (string, string, []backend.Attachment, error)
 				att.ContentID = strings.Trim(cid, "<>")
 			}
 			attachments = append(attachments, att)
-		} else if contentType == "text/html" {
+		case contentType == "text/html":
 			htmlBody = string(data)
-		} else if contentType == "text/plain" && bodyText == "" {
+		case contentType == "text/plain" && bodyText == "":
 			bodyText = string(data)
 		}
 	}
@@ -472,7 +474,7 @@ func findAttachmentData(r io.Reader, targetPartID string) ([]byte, error) {
 	var scanErr error
 	for {
 		part, err := mr.NextPart()
-		if err == io.EOF {
+		if errors.Is(err, io.EOF) {
 			break
 		}
 		if err != nil {

calendar/calendar.go

@@ -116,7 +116,7 @@ func GenerateRSVP(originalData []byte, userEmail, response string) ([]byte, erro
 			// Attendee not found in original - add ourselves with full parameters
 			vevent.AddAttendee("mailto:"+userEmail,
 				ics.WithRSVP(true),
-				ics.ParticipationStatus(ics.ParticipationStatusNeedsAction),
+				ics.ParticipationStatusNeedsAction,
 				ics.CalendarUserTypeIndividual,
 				ics.ParticipationRoleReqParticipant,
 			)

cli/config.go

@@ -26,7 +26,7 @@
 		name := args[0]
 		// Add .lua extension if not present
 		if filepath.Ext(name) != ".lua" {
-			name = name + ".lua"
+			name += ".lua"
 		}
 		target = filepath.Join(home, ".config", "matcha", "plugins", name)
 	}
@@ -35,7 +35,7 @@
 		return fmt.Errorf("file not found: %s", target)
 	}
 
-	cmd := exec.Command(editor, target)
+	cmd := exec.Command(editor, target) //nolint:gosec,noctx
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr

cli/contacts_export.go

@@ -101,7 +101,7 @@ func runExportContacts(format, outputPath string, noHeader bool) error {
 	if outputPath != "" {
 		dir := filepath.Dir(outputPath)
 		if dir != "." {
-			if err := os.MkdirAll(dir, 0755); err != nil {
+			if err := os.MkdirAll(dir, 0750); err != nil {
 				return fmt.Errorf("failed to create output directory: %w", err)
 			}
 		}

cli/install.go

@@ -24,11 +24,11 @@
 	if strings.HasPrefix(source, "http://") || strings.HasPrefix(source, "https://") {
 		// Download from URL
 		client := httpclient.New(httpclient.InstallTimeout)
-		resp, err := client.Get(source)
+		resp, err := client.Get(source) //nolint:noctx
 		if err != nil {
 			return fmt.Errorf("failed to download: %w", err)
 		}
-		defer resp.Body.Close()
+		defer resp.Body.Close() //nolint:errcheck
 
 		if resp.StatusCode != http.StatusOK {
 			return fmt.Errorf("download returned status %d", resp.StatusCode)
@@ -62,7 +62,7 @@
 	}
 
 	dest := filepath.Join(pluginsDir, filename)
-	if err := os.WriteFile(dest, data, 0644); err != nil {
+	if err := os.WriteFile(dest, data, 0644); err != nil { //nolint:gosec
 		return fmt.Errorf("failed to write plugin: %w", err)
 	}
 
@@ -76,7 +76,7 @@
 		return "", fmt.Errorf("cannot find home directory: %w", err)
 	}
 	dir := filepath.Join(home, ".config", "matcha", "plugins")
-	if err := os.MkdirAll(dir, 0755); err != nil {
+	if err := os.MkdirAll(dir, 0750); err != nil {
 		return "", fmt.Errorf("cannot create plugins directory: %w", err)
 	}
 	return dir, nil