Skip to content

feat: spellcheck and suggestions#1362

Merged
steveevansdev merged 3 commits into
floatpane:masterfrom
andrinoff:feat/spellcheck
May 26, 2026
Merged

feat: spellcheck and suggestions#1362
steveevansdev merged 3 commits into
floatpane:masterfrom
andrinoff:feat/spellcheck

Conversation

@andrinoff
Copy link
Copy Markdown
Member

What?

Adds spellcheck library, dict CLI command, suggestions, and more

Why?

Closes #1160

Co-authored-by: Drew Smirnoff <drew@floatpane.com>
Co-authored-by: Andriy Chernov <andriy@floatpane.com>
Co-authored-by: Steve Evans <steve@floatpane.com>
@andrinoff andrinoff requested a review from a team as a code owner May 25, 2026 14:31
@floatpanebot floatpanebot added area/tui Terminal UI / view layer area/i18n Localization / translations enhancement New feature or request area/config Configuration / settings area/cli CLI flags / commands area/docs Docs site / README size/XL Diff: 800+ lines and removed enhancement New feature or request area/tui Terminal UI / view layer area/i18n Localization / translations area/config Configuration / settings area/cli CLI flags / commands area/docs Docs site / README labels May 25, 2026
@andrinoff andrinoff added enhancement New feature or request area/tui Terminal UI / view layer area/i18n Localization / translations area/cli CLI flags / commands area/docs Docs site / README labels May 25, 2026
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot floatpanebot added the area/config Configuration / settings label May 25, 2026
Signed-off-by: drew <me@andrinoff.com>
@floatpanebot
Copy link
Copy Markdown
Member

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Copy Markdown
Member

@steveevansdev steveevansdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid

@steveevansdev steveevansdev merged commit e0cb01c into floatpane:master May 26, 2026
27 checks passed
@floatpane floatpane deleted a comment from andrinoff May 26, 2026
@FromSi
Copy link
Copy Markdown
Member

FromSi commented May 26, 2026

Right now spellcheck.Highlight processes the composer body line by line, and the composer calls it with skipLine = -1, so fenced code blocks are checked like normal prose. For example, words inside:

image

@andrinoff
Copy link
Copy Markdown
Member Author

yes, but code blocks are not usually written in emails, will add a detection for code, when we do the developer update (will come with v1). For now, it is consumer grade function, which can be turned off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli CLI flags / commands area/config Configuration / settings area/docs Docs site / README area/i18n Localization / translations area/tui Terminal UI / view layer enhancement New feature or request size/XL Diff: 800+ lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Spell-check in composer

5 participants