feat: secure passwords (#193)#194
Merged
andrinoff merged 2 commits intofloatpane:masterfrom Feb 25, 2026
Merged
Conversation
Member
Author
|
demos generate correctly, no issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193
Changes:
Previously all passwords were kept in the form of:
Where passwords were kept as plaintext.
Now, using the
go-keyringlibrary, we store the passwords in the OS keyring securely.New config file:
Added
keyring.MockInitto initialize a mocking memory store for testing purposes"github.com/zalando/go-keyring"and all the dependencies that come along.The new changes will NOT require users to adapt to the changes.
The
LoadConfigfunction has been changed to detect old config with the plaintext password and move it to OS keyring, deleting the plaintext detected.10.8MB --> 11.2MB