Conversation
Signed-off-by: drew <me@andrinoff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #217
Add STARTTLS and InsecureSkipVerify support for local proxies
Changes:
config/config.goAdded an Insecure boolean flag to the
AccountandrawAccountstructs.Updated
LoadConfigJSON unmarshaling to parse and map the "insecure" field from the configuration file.fetcher/fetcher.goModified the
connect()function to check the configured IMAP port.Added fallback to establish a standard TCP connection (
client.Dial) and upgrade it via StartTLS when standard unencrypted ports (1143, 143) are used, rather than forcing implicit TLS (client.DialTLS).Injected
tls.Config{InsecureSkipVerify: account.Insecure}into both connection methods to bypass strict certificate validation when the flag is enabled.sender/sender.gosmtp.SendMailwith a manually unrolled SMTP transaction (Dial,Hello,StartTLS,Auth,Data,Quit).This allows the injection of a custom
tls.ConfigwithInsecureSkipVerifyduring the STARTTLS phase, which is not supported by the defaultsmtp.SendMailimplementation.