fix: add ansi colors for TTY support#348
Draft
andrinoff wants to merge 1 commit intofloatpane:masterfrom
Draft
Conversation
Signed-off-by: drew <me@andrinoff.com>
andrinoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added explicit ANSI (8/16 color) fallbacks for theme colors that downsample poorly on Linux TTYs.
Why?
When running matcha on a real Linux TTY (which only supports 8/16 colors), bubbletea's automatic color downsampling produces unreadable results. Colors like
240,241,243(used for secondary/muted text) all map to ANSI8(dark gray), which is invisible on a black TTY background. The tip color214(orange) maps to ANSI9(red), which is misleading.This uses
lipgloss.Complete()withcolorprofile.Detect()to hand-pick readable ANSI fallbacks — light gray (7) for muted text, bright yellow (11) for tips/warnings, and red (1) for danger — while keeping the existing ANSI256/TrueColor values unchanged for normal terminal emulators.Fixes #289