Merged
Conversation
config/config.go had five keyring calls whose errors were swallowed via `_ =`: three keyring.Set paths in SaveConfig and legacy password migration, and two keyring.Delete paths in RemoveAccount. When the OS keyring is absent, locked, or otherwise unhappy, the account password and PGP PIN silently fail to persist; on restart the user is asked to re-authenticate with no indication that keyring storage failed. Log a warning on each failure so the misconfiguration surfaces in the logs. For the Delete paths, swallow keyring.ErrNotFound (expected when the entry never existed or was already cleaned up) but log anything else. No behaviour change on keyring success. Fixes floatpane#616 Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
andrinoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
config/config.gohas five keyring calls whose errors are swallowed with_ =:SaveConfig:keyring.Setforacc.Passwordandacc.Password + ":pgp-pin"keyring.Set(rawAcc.Email, rawAcc.Password)RemoveAccount:keyring.Deleteforacc.Emailand:pgp-pinIf the OS keyring is unavailable, locked, or otherwise unhappy, the
password and PGP PIN silently fail to persist. The user is then asked to
reauthenticate on every restart with no indication that keyring storage
ever failed. Same pattern reported in #616.
Fix
Log a warning on each failure:
For the two
Deletepaths, swallowkeyring.ErrNotFound(expected whenthe entry never existed or was already cleaned up) and log anything else.
No behaviour change on keyring success. Adds
logto the import list.Fixes #616