fix: validate PGPKeySource field on config load#676
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 18, 2026
Merged
fix: validate PGPKeySource field on config load#676andrinoff merged 1 commit intofloatpane:masterfrom
andrinoff merged 1 commit intofloatpane:masterfrom
Conversation
PGPKeySource accepted any string without validation, causing silent failures when an invalid value was used. Now rejects values other than "file" or "yubikey" with a clear error message at config load time. Closes floatpane#620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PGPKeySource accepted any string without validation. An invalid value like
pgp_key_source: "invalid"would load successfully but cause silent failures when the code later assumes the value is"file"or"yubikey".Added validation in
LoadConfig()immediately after the account struct is constructed. Now rejects invalid values with a clear error message at startup rather than failing silently at runtime.Closes #620