Empty commits are made when using git backend on each refresh

[romfir]

Which version of floccus are you using?

5.5.3

How many bookmarks do you have, roughly?

4k

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Git

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Opera 118.0.5461.60, also happens on Edge Mobile Canary (while insalled manually via CRX file)

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Floccus is makind empty commit on each refresh

Expected Behavior

Commit should be made only when there are any differences

To Reproduce

1. Use Floccus with git backend (I'm using password protected one with XBEL format)
2. Click "Sync now" button without any changes to local bookmarks
3. Observe empty commit on your git server

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved. Let me give you a short introduction on what to expect from this issue tracker to avoid misunderstandings.
I'm Marcel. I created floccus a few years ago, and have been maintaining it since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient. It helps when you stick around to answer follow up questions I may have,
as very few bugs can be fixed directly from the first bug report, without any interaction. If information is missing in your bug report
and the issue cannot be solved without it, I will have to close the issue after a while.
Note also that GitHub in general is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
If you cannot lend a helping hand, to continue the development and maintenance of this project in a sustainable way,
I ask that you donate to the project when opening an issue (or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

Thank you for reading through this primer. I look forward to working with you on this issue!
Cheers 💙

[marcelklehr]

Hello @romfir

Thank you for giving feedback by opening this issue! I was able to reproduce this just now and will fix this with the next release.

[elvisisvan]

also happening on vivaldi browser same floccus version 5.5.3 i ended up squashing all empty commits with a commit that has actual changes

[marcelklehr]

Thank you for reminding me that this is still happening. I am well aware and am planning to do a new release on Wednesday. Thank you for your patience.

[pascal-hofmann]

@marcelklehr Unfortunately this is still an issue with both Floccus 5.6.0 and 5.7.0. :(