Replace localforage with browser extension storage. Fixes #459#480
Merged
marcelklehr merged 3 commits intofloccusaddon:developfrom Apr 4, 2020
Merged
Replace localforage with browser extension storage. Fixes #459#480marcelklehr merged 3 commits intofloccusaddon:developfrom
marcelklehr merged 3 commits intofloccusaddon:developfrom
Conversation
Member
|
Thanks for taking this on. Dumping localforage makes me sad in a way, as it is more performant than the normal extension storage, but I guess the main bottleneck is not the storage. |
marcelklehr
requested changes
Apr 2, 2020
Contributor
Author
|
@marcelklehr your requested changes should be handled. Thanks for the review. |
marcelklehr
approved these changes
Apr 4, 2020
marcelklehr
reviewed
Apr 5, 2020
| localForage.getItem('accounts') | ||
| .then(async d => { | ||
| if (!d.accounts) return | ||
| return AccountStorage.changeEntry('accounts', () => d.accounts) |
Member
There was a problem hiding this comment.
Gnaaa, this doesn't work. I should have noticed.
Contributor
Author
There was a problem hiding this comment.
hm, I'm sorry to hear that. I tested the upgrade process using the version of the develop branch and had success getting my accounts to update.
I guess its a problem if you are coming from an older version that had the browser storage to begin with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts some changes from da085e0 and 5739a5c.